search

fitnr / convertdate

Utils for converting between date formats and calculating holidays
MIT License
47 stars 24 forks source link

Add alternate conversions for Islamic calendar #41

Closed xayhewalo closed 3 years ago

xayhewalo commented 3 years ago

Fixes #40

The source I used could probably be used for other calendars, but no need to fix something that's not broken

fitnr commented 3 years ago

I think it would make sense to retain a single function for this conversion. Does this function pass all of the tests for the current islamic.from_jd function? If so, I would be happy to switch the algorithm to this. If not, can you add a conditional that selects which agorithm based on a cutover date?

fitnr commented 3 years ago

Fixed the bug in the current function.