search

fitzgen / bumpalo

A fast bump allocation arena for Rust
https://docs.rs/bumpalo
Apache License 2.0
1.36k stars 111 forks source link

Fix docs, Bump is !Sync, not !Send #118

Closed untitaker closed 2 years ago

untitaker commented 2 years ago

cc @vorner who added this paragraph

vorner commented 2 years ago

cc @vorner who added this paragraph

I guess I just wasn't paying enough attention and confused the two. The docs and compiler seems to agree with you, not with me ;-)

untitaker commented 2 years ago

thanks it's just I have no idea what I am doing and wanted more eyes on it

fitzgen commented 2 years ago

The valgrind failure is the cargo readme-is-up-to-date test failing. @untitaker can you run cargo readme -t README.tpl > README.md so that the README.md is synced with the module level docs? That should fix this failure.

The rust 1.44 CI failure looks like cargo readme doesn't build on rust 1.44 anymore, and is unrelated to this crate actually building on rust 1.44. I think we can either:

I don't have time to do this latter fix myself at the moment, so if you have time @untitaker that would be super appreciated. Or anyone else!

untitaker commented 2 years ago

Do you want to keep the cargo readme test in the rust testsuite at all costs? I was thinking that this could be its own CI-job which auto-pushes the readme update for PRs

fitzgen commented 2 years ago

That works for me too

fitzgen commented 2 years ago

cargo-readme fix is over in https://github.com/fitzgen/bumpalo/pull/122

untitaker commented 2 years ago

sorry for dropping the ball on this, rebased PR!