Switch from `quickcheck` to `cargo-fuzz`

fitzgen / bumpalo

A fast bump allocation arena for Rust

https://docs.rs/bumpalo

Apache License 2.0

1.41k stars 111 forks source link

Switch from `quickcheck` to `cargo-fuzz` #167

Open zetanumbers opened 2 years ago

zetanumbers commented 2 years ago

quickcheck tests are super long for miri (14m24s enabled vs. 1m48s disabled). Perhaps it is better to separate "try to break the program by massaging input for a while" tests and usual tests? cargo-fuzz defines fuzz targets, which already are separate from tests.

fitzgen commented 2 years ago

Happy to receive a PR doing this.

fitzgen commented 2 years ago

Would need to run each of the fuzz targets on CI (in separate jobs so we get parallelism) for ~5 minutes as well.

zetanumbers commented 2 years ago

For now i made it possible to not enable quickcheck via similarly named feature in #168.

zetanumbers commented 2 years ago

I think it could be better to not switch to cargo-fuzz if we would run 1 test in quickcheck. This would allow to check UB in the quickcheck! code. However it would be desirable to write some predefined values to increase code coverage and for determinism.