search

fitzgen / bumpalo

A fast bump allocation arena for Rust
https://docs.rs/bumpalo
Apache License 2.0
1.35k stars 110 forks source link

3.11.1 broke backwards-compatibility #182

Closed muglug closed 1 year ago

muglug commented 1 year ago

This fix changed what I think is a public API.

Should that have landed in a major version?

fitzgen commented 1 year ago

It's a slightly tricky thing. It is technically a breaking change, but since it is a security fix I wanted it to be on the 3.x series. I feel like there isn't really an absolute right answer for what to do in this situation and people could argue either way. I made a choice and am going to stick with that choice. Hope it wasn't too much of a hassle for you.