Open sivadeilra opened 3 months ago
Happy to take a PR that adds a zeroing allocation method, but I don't want to take a dependency on any new crates.
It's an optional dependency, though, and the zerocopy
crate is part of the Safe Transmute initiative.
The zerocopy crate provides traits and functions for safely transmuting types to/from bytes. It is an important building block for high-performance serialization in many designs. It is also a very well-maintained crate with high standards for quality and its maintainers are actively engaged with the Rust Project on advancing the goals of the Safe Transmute working group.
The
zerocopy
crate defines theFromZeroes
trait, which specifies that a type can be safely constructed from a buffer containing an all-zeroes bit pattern.This PR adds two new methods to
Bump
:new_zeroed
andnew_slice_zeroed
.new_zeroed
allocates space forT
(whereT: FromZeroes
) and returns&mut T
. This avoids the "placement new" problem in Rust, which causes problems when attempting to allocate large types in the heap, such as[u8; 0x10000]
. For most containers, such asBox
, the type is briefly constructed in a temporary on the stack, then a heap allocation is done, then the value is moved into the heap allocation. IfT
is large enough, it can cause stack overflow.The
Bump::new_zeroed
function avoids this problem by simply allocating space forT
directly in the heap, then filling it with zeroes, then casting the allocation as&mut T
and returning it. TheFromZeroes
constraint ensures that this is sound.The
new_slice_zeroed
function similarly allows allocating slices directly in a Bump.