search

fitzgen / bumpalo

A fast bump allocation arena for Rust
https://docs.rs/bumpalo
Apache License 2.0
1.39k stars 110 forks source link

Layout::array has been stabilized #77

Closed TethysSvensson closed 4 years ago

TethysSvensson commented 4 years ago

The function Layout::array has been stabilized.

This means that the TODO in lib.rs can finally be fixed. The fix would mean that we will no longer have to do defensive coding in layout_for_array. I think this might also be a small reduction in the generated code size, but I haven't actually tested it.

However given that 1.44 has just been stabilized, now is probably not the time to begin depending on it. Do you think we should perhaps create a version policy for bumpalo?

fitzgen commented 4 years ago

I'm happy to document the MSRV and feel free to bump it in Y versions in X.Y.Z.

TethysSvensson commented 4 years ago

In that case, I will do a PR which fixes the TODO and adds a note in the README about the MRSV.

I think it would probably also be helpful to test the MSRV as part of the CI workflow, though I don't understand that workflow well enough to update it myself.

fitzgen commented 4 years ago

Fixed in #79