Use Rust edition 2018 - Githubissues

fitzgen / inlinable_string

An owned, grow-able UTF-8 string that stores small strings inline and avoids heap-allocation.

http://fitzgen.github.io/inlinable_string/inlinable_string/index.html

Other

69 stars 11 forks source link

Use Rust edition 2018 #23

Closed lo48576 closed 3 years ago

lo48576 commented 4 years ago

Applied cargo fix --edition-idioms. Rust compiler can link edition 2015 crates and edition 2018 crates, so this update is non-breaking.

ArtemGr commented 4 years ago

Unless someone is using a very old compiler? Maybe it is still prudent to bump the version? @fitzgen , do you have an opinion on this?

fitzgen commented 4 years ago

Seems fine to do a version bump -- not hard for folks to upgrade.

lo48576 commented 4 years ago

FYI: Rust edition 2018 is supported since Rust 1.31.0, and Debian jessie (old!) repository has rustc-1.34.2.

However, I didn't tested the code to compile on rust 1.31 or other old versions, so it would be better to make MSRV explicit and add CI tests (cc: #20).