Open erikrose opened 8 years ago
Sure, I would accept a PR with these methods and test coverage for them.
I think that by
should instead be a -1 | 0 | 1
style comparator function, like what Array.prototype.sort
takes.
👍
While you're at it, complementing max
with min
would be nice!
I just switched https://github.com/mozilla/fathom from lodash to wu because lodash isn't very interested in supporting ES6 iterables. However, that meant I had to bring my own max() and sum() functions. Would you consider a PR for them in wu? I wrote them so they're polymorphic, able to be used on numbers, strings, or whatever supports the
>
operator, without any undue casting influence from a static initializer.Thanks for considering, and thanks for filling a big hole with wu!