search

fitztrev / laravel-html-minify

Minifies the HTML output of Laravel 4 applications
https://github.com/fitztrev/laravel-html-minify/wiki/Laravel-5---5.1-HTML-Minifying
MIT License
415 stars 76 forks source link

Update LaravelHtmlMinifyServiceProvider.php #23

Closed ddjikic closed 10 years ago

ddjikic commented 10 years ago

replaced $app['path'].'/storage with storage_path() it will work where ever you storage dir is

fitztrev commented 10 years ago

@ddjikic Thanks for the pull request. Could you please update it to include only the change in LaravelHtmlMinifyServiceProvider.php? Once you do that, let's make sure the build passes and then I'll merge.

ddjikic commented 10 years ago

sorry did not realized that it will want to merge with yours i did a previous commit with only the code changes and it passed travis , because you did not replied for the pull yesterday i forked and fixed so i can use it in my project... i will change and add a tag so you can merge but if you want delete the pull and only do line 36 $cachePath = storage_path().'/views';

fitztrev commented 10 years ago

Ah, re: #22, yeah I didn't see it until now. That looks like it would be right though if you want to make another PR.

ddjikic commented 10 years ago

https://github.com/fitztrev/laravel-html-minify/pull/24