fiuhonors / myhonors-old

A fast, modern infrastructure and social base for students, faculty, and staff. Developed for The Honors College at Florida International University.
http://myhonors.fiu.edu
2 stars 1 forks source link

Change the attendance table structure so the 'pid' field is renamed to 'userid' and is of type varchar(7) #6

Closed sergiopantoja closed 11 years ago

sergiopantoja commented 11 years ago

We may want to further expand varchar to allow for longer ID number strings that may be used in other schools.

crow1170 commented 11 years ago

This is very close to issue #5, and can be solved the same way. If a Uni is using some ID bigger that 10^7 then it's probably a social number or a state ID and they shouldn't be using it anyway.
I think 'pid' is good because it can imply user roles- pid is how they are referenced as a student, userid is how they are referenced as an admin.

sergiopantoja commented 11 years ago

This is very close to issue #5, and can be solved the same way. If a Uni is using some ID bigger that 10^7 then it's probably a social number or a state ID and they shouldn't be using it anyway.

Okay yes. I searched the web and I found that many other universities use a 7-digit ID too.

I think 'pid' is good because it can imply user roles- pid is how they are referenced as a student, userid is how they are referenced as an admin.

True, but we now know that user roles will be handled by Tank Auth v2.0, so I think we're safe to change "pid" to "userid" now to make it more easily understood.