search

fiuneuro / brainconn

A Python implementation of the brain connectivity toolbox. **Not actively maintained.**
https://brainconn.readthedocs.io
GNU General Public License v3.0
30 stars 21 forks source link

Fix style problems #10

Closed tsalo closed 2 years ago

tsalo commented 6 years ago

We can see a list of style mistakes in the flake Travis test here (this may become outdated as we open more PRs and make changes, so please refer to the most recent tests or run flake locally). These mistakes should be very easy to fix, but may take some time because there are so many.

tsalo commented 6 years ago

Most of the style issues are solved in #25. The remaining ones, per flake8, are:

brainconn/__init__.py:17:1: F401 '.version.__version__' imported but unused
brainconn/tests/test_centrality.py:63:80: E501 line too long (81 > 79 characters)
brainconn/utils/visualization.py:102:80: E501 line too long (81 > 79 characters)

There are still a lot of style problems in the code not caught by flake8, especially unpythonic variable names (e.g., I, A, C).