fiuneuro / brainconn

A Python implementation of the brain connectivity toolbox. **Not actively maintained.**
https://brainconn.readthedocs.io
GNU General Public License v3.0
30 stars 21 forks source link

[REF] Remove BCTParamError #36

Closed mattfeld closed 6 years ago

mattfeld commented 6 years ago

Closes #29.

Changes proposed in this pull request:

tsalo commented 6 years ago

There are a couple of bugs that need to be fixed, which flake8 caught here. Specifically, it looks like RunTimeError should be RuntimeError, ValueError was mistyped as ValueErro once, there are a few lines that are too long, and there are a couple of other random spacing errors.

codecov-io commented 6 years ago

Codecov Report

Merging #36 into master will decrease coverage by 0.02%. The diff coverage is 12.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   41.61%   41.58%   -0.03%     
==========================================
  Files          41       41              
  Lines        5006     4999       -7     
==========================================
- Hits         2083     2079       -4     
+ Misses       2923     2920       -3
Impacted Files Coverage Δ
brainconn/utils/misc.py 72.72% <ø> (-1.56%) :arrow_down:
brainconn/utils/matrix.py 60.81% <0%> (-0.53%) :arrow_down:
brainconn/utils/visualization.py 3.38% <0%> (-0.33%) :arrow_down:
brainconn/generative/generative.py 2.04% <0%> (-0.29%) :arrow_down:
brainconn/nbs.py 77.98% <0%> (-0.21%) :arrow_down:
brainconn/core/core.py 49.79% <0%> (-0.21%) :arrow_down:
brainconn/utils/__init__.py 100% <100%> (ø) :arrow_up:
brainconn/motifs/motifs.py 3.08% <25%> (ø) :arrow_up:
brainconn/clustering/clustering.py 60.53% <33.33%> (ø) :arrow_up:
brainconn/similarity/similarity.py 8.51% <33.33%> (ø) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9cc89b...3efac8b. Read the comment docs.

tsalo commented 6 years ago

Looks good to me. Will merge once tests pass. Thanks!