Make age extraction more flexible

[tsalo]

@anthonystevendick reported a bug where age extraction may fail:

Traceback (most recent call last):
  File "/scripts/run.py", line 104, in <module>
    main()
  File "/scripts/run.py", line 91, in main
    age = int(data.PatientAge.replace('Y', ''))
ValueError: invalid literal for int() with base 10: '004M'

In the above case, the subject's age is 4 months, but the age extraction code assumes that the subject's age is reported in years.

Participants this young are rare, so this is a low priority bug to fix.

[anthonystevendick]

Hello Taylor,

This was a typo from the scanner tech. This is supposed to say years (we don’t scan younger than 4 years).

Anthony

-- Anthony Steven Dick, Ph.D. Associate Professor Director, Cognitive Neuroscience Program and Graduate Certificate in Cognitive Neuroscience Florida International University MM Campus AHC4 454 Department of Psychology and Center for Children and Familieshttp://www.ccf.fiu.edu/, an FIU Preeminent Programhttps://beyondpossible.fiu.edu/preeminent-programs/ 11200 S.W. 8th Street Miami, FL 33199 Ph: 305-348-4202; Lab Ph: 305-348-9055; Fx: 305-348-3879 Email: adick@fiu.edumailto:adick@fiu.edu; Webpage: http://dcn.fiu.eduhttp://dcn.fiu.edu/; Join the SSHDhttp://www.sshdonline.org/

Check out the new bookhttp://www.routledge.com/9781138960039: Dick, A.S., & Müller, U. (2018). Advancing Developmental Science: Philosophy, Theory, and Method. Taylor & Francis.

From: Taylor Salo notifications@github.com Reply-To: FIU-Neuro/cis-processing reply@reply.github.com Date: Wednesday, September 12, 2018 at 10:02 AM To: FIU-Neuro/cis-processing cis-processing@noreply.github.com Cc: Anthony Dick adick@fiu.edu, Mention mention@noreply.github.com Subject: [FIU-Neuro/cis-processing] Make age extraction more flexible (#25)

@anthonystevendickhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_anthonystevendick&d=DwMCaQ&c=lhMMI368wojMYNABHh1gQQ&r=DmdQWjwCJRFVHJCqLOrjwA&m=M2Nsay1Dl9qynUyoACpKzVyG7JutrQ62gMHQUmURtpc&s=eYfDj6UWT5uG1qIsZyoc_KStQBBKn72VIC_czIw0-tg&e= reported a bug where age extraction may fail:

Traceback (most recent call last):

File "/scripts/run.py", line 104, in

main()

File "/scripts/run.py", line 91, in main

age = int(data.PatientAge.replace('Y', ''))

ValueError: invalid literal for int() with base 10: '004M'

In the above case, the subject's age is 4 months, but the age extraction code assumes that the subject's age is reported in years.

Participants this young are rare, so this is a low priority bug to fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_FIU-2DNeuro_cis-2Dprocessing_issues_25&d=DwMCaQ&c=lhMMI368wojMYNABHh1gQQ&r=DmdQWjwCJRFVHJCqLOrjwA&m=M2Nsay1Dl9qynUyoACpKzVyG7JutrQ62gMHQUmURtpc&s=mIYt-9odz17tCk3PIcds6D2eBROMBPpymsv7tUOdmco&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AeBVSS3XIyev3wrZjHHIFtxOXXgTereIks5uaRPqgaJpZM4Wlc7X&d=DwMCaQ&c=lhMMI368wojMYNABHh1gQQ&r=DmdQWjwCJRFVHJCqLOrjwA&m=M2Nsay1Dl9qynUyoACpKzVyG7JutrQ62gMHQUmURtpc&s=Inr17XGCiXvoU5syagw0aKMvhe2b1WSPnDpId9wErt0&e=.

[tsalo]

That's true, but that typo did expose a bug in the cis-processing code. Even in cases where there is a minor typo like that, I think it's better to err on the side of letting the mistake through, since people should check their outputs anyway. I see not being able to even run the converter on your data because of a small typo a mistake on the converter's (my) end.

[tsalo]

Fixed in cis-bidsify.