fivdi / epoll

A low-level Node.js binding for the Linux epoll API
MIT License
84 stars 13 forks source link

nan 1.0.0 alignment #8

Closed fivdi closed 10 years ago

fivdi commented 10 years ago

A number of things need to be adjusted when nan 1.0.0 is released.


NanAssignPersistent has two parameters rather than three, the first is no longer required, so

NanAssignPersistent(v8::FunctionTemplate, constructor, ctor);

becomes

NanAssignPersistent(constructor, ctor);

There's now a NanNew function template and template specializations for creating new v8 objects. See also NanUndefined, NanNull, NanTrue, and NanFalse. They hide the isolate dependencies. For example

v8::FunctionTemplate::New(Epoll::New)

becomes

NanNew<v8::FunctionTemplate>(Epoll::New)

NanNewLocal has been removed and NanNew should be used as a replacement, so if NanNull is also used

NanNewLocal<v8::Value>(v8::Null())

becomes

NanNew(NanNull())

Are any other alignments required?

fivdi commented 10 years ago

Done with 2fe221a0227809341319a25d14350dcba722492d