search

fiveai / Cachet

📛 An open source status page system for everyone.
https://cachethq.io
BSD 3-Clause "New" or "Revised" License
101 stars 28 forks source link

Don't use last component group id for "other" section on subscription page #16

Closed sedan07 closed 3 years ago

sedan07 commented 3 years ago

Otherwise this breaks then there aren't any component groups as it cannot use the last value the var was assigned as it never happened. #8

codecov-io commented 3 years ago

Codecov Report

Merging #16 (2df9220) into 2.5 (3947f0d) will increase coverage by 0.93%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.5      #16      +/-   ##
============================================
+ Coverage     53.09%   54.03%   +0.93%     
  Complexity     1264     1264              
============================================
  Files           275      275              
  Lines          4799     4799              
============================================
+ Hits           2548     2593      +45     
+ Misses         2251     2206      -45
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/SubscribeController.php 52.11% <100.00%> (+49.29%) 20.00 <0.00> (ø)
app/Integrations/Core/System.php 92.30% <0.00%> (+5.12%) 13.00% <0.00%> (ø%)
app/Models/Subscriber.php 100.00% <0.00%> (+8.00%) 11.00% <0.00%> (ø%)
...ions/Subscriber/ManageSubscriptionNotification.php 22.22% <0.00%> (+22.22%) 2.00% <0.00%> (ø%)
app/Http/Middleware/SubscribersConfigured.php 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3947f0d...2df9220. Read the comment docs.