fiveai / Cachet

📛 An open source status page system for everyone.
https://cachethq.io
BSD 3-Clause "New" or "Revised" License
101 stars 28 forks source link

Ignore modal styles "swal2" when purging unused CSS #20 #27

Closed sedan07 closed 3 years ago

sedan07 commented 3 years ago

The CSS for the modal window was missing as it gets added dynamically to the HTML. Ignoring anything prefixed with swal2- when purging unused styles seems to solve the issue.

codecov-io commented 3 years ago

Codecov Report

Merging #27 (5ed3464) into 2.5 (b797f36) will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.5      #27      +/-   ##
============================================
+ Coverage     55.88%   55.92%   +0.04%     
  Complexity     1264     1264              
============================================
  Files           275      275              
  Lines          4803     4803              
============================================
+ Hits           2684     2686       +2     
+ Misses         2119     2117       -2     
Impacted Files Coverage Δ Complexity Δ
app/Integrations/Core/System.php 87.17% <0.00%> (+2.56%) 13.00% <0.00%> (ø%)
app/Presenters/ComponentPresenter.php 100.00% <0.00%> (+5.26%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b797f36...5ed3464. Read the comment docs.