search

fiveai / Cachet

📛 An open source status page system for everyone.
https://cachethq.io
BSD 3-Clause "New" or "Revised" License
101 stars 28 forks source link

Update dashboard.php #31

Closed Yves911 closed 3 years ago

Yves911 commented 3 years ago

Few additional translation

codecov-io commented 3 years ago

Codecov Report

Merging #31 (d769e32) into 2.5 (747d52e) will decrease coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.5      #31      +/-   ##
============================================
- Coverage     55.89%   55.76%   -0.13%     
  Complexity     1265     1265              
============================================
  Files           275      275              
  Lines          4804     4804              
============================================
- Hits           2685     2679       -6     
- Misses         2119     2125       +6
Impacted Files Coverage Δ Complexity Δ
app/Integrations/Core/System.php 79.48% <0.00%> (-10.26%) 13.00% <0.00%> (ø%)
app/Presenters/ComponentPresenter.php 94.73% <0.00%> (-5.27%) 10.00% <0.00%> (ø%)
app/Http/Controllers/Dashboard/ApiController.php 50.00% <0.00%> (-2.50%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 747d52e...d769e32. Read the comment docs.

sedan07 commented 3 years ago

@Yves911 thanks for these.

In future if you have multiple translation changes just pop in one PR for them all rather than separate ones for each one as it makes sense for them all to be grouped under the functionality of "french translations" which file has changes doesn't really matter.