search

fivecar / react-native-draglist

FlatList that can be reordered by dragging its items
MIT License
119 stars 19 forks source link

Rename onStartDrag to onDragStart, etc #17

Closed charlestbell closed 1 year ago

charlestbell commented 1 year ago

Hello, me again.

This is more of a discussion topic, but there isn't a discussion option on this repo, so here I am.

For a future version of the API, may I suggest changing onStartDrag => onDragStart onEndDrag => onDragEnd

to more closely match other, similar packages and apis.

It seems like a small thing, but it has created an issue for me 3 times now. I typed it wrong, and I was scratching my head wondering why nothing was working.

Thanks again for an excellent package!

fivecar commented 1 year ago

Such great feedback. Done with #18. Launched with https://github.com/fivecar/react-native-draglist/releases/tag/3.5.0.