search

fivefilters / block-ads

Web page to test ad blocking and encourage use of blockers.
https://blockads.fivefilters.org
GNU Affero General Public License v3.0
179 stars 15 forks source link

HTML5 validation #7

Closed ghost closed 8 years ago

ghost commented 8 years ago

I ran block-ads through https://validator.w3.org and everything validated for HTML5 except for the missing alt text in images. This pull request ensures fully valid HTML5.

ghost commented 8 years ago

This pull request has some conflicts because...

I had to manually apply some of your commits because in https://github.com/fivefilters/block-ads/commit/2ab585b8a7ef4bc8fd9a7d9b977fbb86af3d37d7 you reverted to an older version of index.html - I had cleaned up the HTML in https://github.com/fivefilters/block-ads/commit/1adbc87c48859367482eb94c1d2e1cd4292b2edd and by reverting to an older version you accidentally overwrote the cleaned up code. By manually applying your edits, we retain the cleaned up version, while ensuring full HTML5 validation.

If you review the commits you'll see I'm bringing your changes from https://github.com/fivefilters/block-ads/commit/2ab585b8a7ef4bc8fd9a7d9b977fbb86af3d37d7 and https://github.com/fivefilters/block-ads/commit/2ca324709ba6034027805a94833a7a3596e9e7dc and applying them to the version of index.html from https://github.com/fivefilters/block-ads/commit/1adbc87c48859367482eb94c1d2e1cd4292b2edd

Hope that makes sense, let me know if you have any questions.