search

fiverr / dangerfile.js

🚫 Centralised dangerfile
MIT License
4 stars 1 forks source link

[Danger] Warn when using raw colors instead of color variables #22

Closed tzooks closed 3 years ago

tzooks commented 3 years ago

Now that the palette colors are available in both JS and SCSS, there should be no reason to use hardcoded colors. This will warn to increase the awareness, and at some point, this will be changed to an error.

Example: https://github.com/fiverr/test_perseus/pull/53 image

This PR will wait for https://github.com/fiverr/anthill/pull/413 to be out, to ensure sass is actually ready to use in perseuses and packages.

FiverrBot commented 3 years ago
Warnings
:warning: Version Bump! - Do you want to publish a new version of this package after merging this PR? Don't forget to bump the version in `package.json` before merging to the master. 📦
:warning: What about unit tests? - It seems like you made some changes, but you did not update/add any tests. 🤔

Generated by :no_entry_sign: dangerJS against b0eed548b2a633c3794d5fd84825b4f3b495ffc9

michael5r commented 3 years ago

Great!