search

fiverr / dangerfile.js

🚫 Centralised dangerfile
MIT License
4 stars 1 forks source link

[FEAT] Add textCapitalizationFail #24

Closed TomerSH17 closed 3 years ago

TomerSH17 commented 3 years ago

Add failure if there is a file that includes text-transform: capitalize and warning if consumption of capitalize method from futile or lodash was detected as this violates the localization rules

This PR should be merged on 16-Aug (capitalization day)

FiverrBot commented 3 years ago
Warnings
:warning: What about unit tests? - It seems like you made some changes, but you did not update/add any tests. 🤔

Generated by :no_entry_sign: dangerJS against 223c1accc14b31caa4cbacd18a37237aa786e9f7

TomerSH17 commented 3 years ago

@raphaelboukara @odeadglaz Regarding fail / warn: I agree that we might want to warn about consumption of capitalize from futile or lodash But text-transform: capitalize in CSS should never be used anymore, so IMO it's better to fail the build in this case

WDYT?

odeadglaz commented 3 years ago

Sure, lets change it

TomerSH17 commented 3 years ago

@odeadglaz @raphaelboukara I made the relevant changes, pls take a look again