fiverr / dangerfile.js

🚫 Centralised dangerfile

MIT License

4 stars 1 forks source link

[FIX] Changelog rule #26

Closed roeezolantz closed 3 years ago

roeezolantz commented 3 years ago

Why

At the moment - the changelog rule runs only if there are changes in BOTH package.json AND in chagelong.md, which is kinda weird, because it should warn if there are no changelog updates for the bumped version, no?

As far as I see - the changelog rule should run once there is a version change in the package.json, and if so - check for changes in the changelog.md

Note : diffForFile returns false if the file provided does not exist, so the changelog diffs validation is safe.

FiverrBot commented 3 years ago

	Warnings
:warning:	CHANGELOG! - Update changelog file with changes made in the version update. ⛔️

Generated by :no_entry_sign: dangerJS against 88b54c2c2cfb40b97822f714b0bebcdb6059e67e