search

fivetanley / ember-cli-migrator

migrate your files to the standard ember-cli structure, preserving git history
MIT License
106 stars 22 forks source link

Migrator stripped window.mixpanel inside mixpanel.js and replaced it just with mixpanel #54

Open igorT opened 9 years ago

igorT commented 9 years ago

Not really sure how/why but this can lead to very hard to track down errors

tonysherbondy commented 9 years ago

Hmmm, I thought we had removed the window stripping. And if we left it, I'm not so sure what it is useful for now?

fivetanley commented 9 years ago

Looks like it is still there, I may have messed this up in a refactoring... https://github.com/fivetanley/ember-cli-migrator/blob/master/lib/migrator-visitor.js#L69

hefox commented 6 years ago

I've had this with window.location as well