search

fivethirtyeight / data

Data and code behind the articles and graphics at FiveThirtyEight
https://data.fivethirtyeight.com/
Creative Commons Attribution 4.0 International
16.7k stars 10.96k forks source link

Please add year scrapped to readme #282

Closed m3gan0 closed 1 year ago

m3gan0 commented 3 years ago

Please add the year the data originates from to the readme in order to easily date it. Thank you!

abitrolly commented 3 years ago

Any ideas how to do this the smart way?

m3gan0 commented 3 years ago

The readme currently reads: The data comes from Marvel Wikiahttp://marvel.wikia.com/Main_Page and DC Wikiahttp://dc.wikia.com/wiki/Main_Page. Characters were scraped on August 24. Appearance counts were scraped on September 2. The month and year of the first issue each character appeared in was pulled on October 6.”

I would just add YYYY after the month to indicate when the data was pulled from the wikis. Ex: “The data comes from Marvel Wikiahttp://marvel.wikia.com/Main_Page and DC Wikiahttp://dc.wikia.com/wiki/Main_Page. Characters were scraped on August 24, 2013. … Appearance counts were scraped on September 2, 2013. The month and year of the first issue each character appeared in was pulled on October 6, 2013.”

(I have no idea if 2013 is the right year BTW) Thank you! Megan (who is using this data set as an example in for a workshop)

From: Anatoli Babenia @.> Sent: Wednesday, June 23, 2021 9:04 AM To: fivethirtyeight/data @.> Cc: O'Donnell, Megan N [LIB] @.>; Author @.> Subject: Re: [fivethirtyeight/data] Please add year scrapped to readme (#282)

Any ideas how to do this the smart way?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/fivethirtyeight/data/issues/282#issuecomment-866865207, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB7INEPU4O6QK7VPRSKK2KLTUHSW3ANCNFSM47F3MWDQ.

walterhickey commented 3 years ago

hey! It was 2014. Here's the story in question: https://fivethirtyeight.com/features/women-in-comic-books/

m3gan0 commented 3 years ago

I made a guess based on GitHub's "last updated 7 years ago" note :-)

abitrolly commented 3 years ago

So that's the README that needs a patch https://github.com/fivethirtyeight/data/tree/master/comic-characters

I thought the request is to adjust all READMEs to contain some kind of machine readable tag with the date.

m3gan0 commented 3 years ago

Yes, sorry for the confusion. It's only the readme for the comic characters that needs a change. Sorry for the confusion, I forgot that it was a subset of the fivethirtyeight repository.

Neil-Paine-1 commented 3 years ago

OK, this should be fixed now!