fivetran / dbt_ad_reporting

Fivetran's ad reporting dbt package. Combine your Facebook, Google, Pinterest, LinkedIn, Twitter, Snapchat, Microsoft, TikTok, Reddit, Amazon, and Apple Search advertising metrics using this package.
https://fivetran.github.io/dbt_ad_reporting/#!/overview
Apache License 2.0
142 stars 56 forks source link

[Bug] Inconsistency in default value for var `twitter_ads__using_keywords` #69

Closed fivetran-catfritz closed 1 year ago

fivetran-catfritz commented 1 year ago

Is there an existing issue for this?

Describe the issue

The default value for twitter_ads__using_keywords is False in some places and True in others. This runs fine if a value for the variable is provided but causes an error if no value is provided since the defaults conflict.

According to the README, the defaults should all be True, but making them all False would also work I assume.

See from int_ad_reporting__keyword_report: https://github.com/fivetran/dbt_ad_reporting/blob/2146d06da804047427cf336e19ce122e7b1dac6e/models/intermediate/int_ad_reporting__keyword_report.sql#L1 vs

https://github.com/fivetran/dbt_ad_reporting/blob/2146d06da804047427cf336e19ce122e7b1dac6e/models/intermediate/int_ad_reporting__keyword_report.sql#L74 and fromad_reporting__keyword_report: https://github.com/fivetran/dbt_ad_reporting/blob/2146d06da804047427cf336e19ce122e7b1dac6e/models/ad_reporting__keyword_report.sql#L1

Relevant error log or model output

No response

Expected behavior

Runs without errors if no value is provided for twitter_ads__using_keywords.

dbt Project configurations

Value for twitter_ads__using_keywords deliberately not provided.

Package versions

packages:

What database are you using dbt with?

bigquery

dbt Version

1.3.0

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-sheringuyen commented 1 year ago

Resolved with release 1.0.3