fivetran / dbt_ad_reporting

Fivetran's ad reporting dbt package. Combine your Facebook, Google, Pinterest, LinkedIn, Twitter, Snapchat, Microsoft, TikTok, Reddit, Amazon, and Apple Search advertising metrics using this package.
https://fivetran.github.io/dbt_ad_reporting/#!/overview
Apache License 2.0
142 stars 56 forks source link

feature/enable-null-urls #72

Closed fivetran-catfritz closed 1 year ago

fivetran-catfritz commented 1 year ago

Are you a current Fivetran customer?

Fivetran created PR. What change(s) does this PR introduce?

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🍝 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-sheringuyen commented 1 year ago

I am going to merge this even though it is still failing databricks. It's the same issue we have been seeing in Google Ads and I believe once that is resolved, this will pass. Oddly, removing it from integration testing is still not completely solving the problem.