fivetran / dbt_ad_reporting

Fivetran's ad reporting dbt package. Combine your Facebook, Google, Pinterest, LinkedIn, Twitter, Snapchat, Microsoft, TikTok, Reddit, Amazon, and Apple Search advertising metrics using this package.
https://fivetran.github.io/dbt_ad_reporting/#!/overview
Apache License 2.0
143 stars 55 forks source link

Fix null values from snapchat_ads package in ad_reporting__url_report #81

Closed dumkydewilde closed 1 year ago

dumkydewilde commented 1 year ago

Are you a current Fivetran customer? Yes, consulting ananalytics engineer @ FTD

What change(s) does this PR introduce? This enables the ad_group (name/id) and campaign (name/id) columns for snapchat ads in ad_reporting__url_report. It is dependent on those being [available in the snapchat ads package (PR#14), hence the changed dependency on the snapchat_ads package in the packages.yml.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:metal: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.