Closed fivetran-joemarkiewicz closed 1 year ago
Changes look good but don't forget to update the version!
Thanks for catching @fivetran-reneeli, this is going to be merged into the release/v1.4.0 branch so the version should be bumped when merging into there. If all else looks good would you be able to approve or add any other comments before merging to the release branch. Thanks!
PR Overview
This PR will address the following Issue/Feature: #77
This PR will result in the following new package version:
v1.4.0
While this isn't technically breaking, it will be included in the next major release. As such we will mark it as breaking.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR includes a new variable
pinterest__using_keywords
that allows users to disable the keywords reports within Pinterest if they are not needed or are not located within the users source schema.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[X] You have validated these changes and assure this PR will address the respective Issue/Feature.
[X] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[X] You have provided details below around the validation steps performed to gain confidence in these changes.
Variable set to
false
with all other ad platforms (excluding amazon ads) enabled.Variable set to
true
with all other ad platforms (excluding amazon ads) enabled.Variable not defined (default) with all other ad platforms (excluding amazon ads) enabled.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📚