fivetran / dbt_ad_reporting

Fivetran's ad reporting dbt package. Combine your Facebook, Google, Pinterest, LinkedIn, Twitter, Snapchat, Microsoft, TikTok, Reddit, Amazon, and Apple Search advertising metrics using this package.
https://fivetran.github.io/dbt_ad_reporting/#!/overview
Apache License 2.0
142 stars 56 forks source link

feature/pinterest-keywords-variable-addition #89

Closed fivetran-joemarkiewicz closed 1 year ago

fivetran-joemarkiewicz commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: #77

This PR will result in the following new package version: v1.4.0

While this isn't technically breaking, it will be included in the next major release. As such we will mark it as breaking.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

This PR includes a new variable pinterest__using_keywords that allows users to disable the keywords reports within Pinterest if they are not needed or are not located within the users source schema.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

📚
fivetran-joemarkiewicz commented 1 year ago

Changes look good but don't forget to update the version!

Thanks for catching @fivetran-reneeli, this is going to be merged into the release/v1.4.0 branch so the version should be bumped when merging into there. If all else looks good would you be able to approve or add any other comments before merging to the release branch. Thanks!