Fivetran's ad reporting dbt package. Combine your Facebook, Google, Pinterest, LinkedIn, Twitter, Snapchat, Microsoft, TikTok, Reddit, Amazon, and Apple Search advertising metrics using this package.
We decided, together with Joe, that we would keep the same variable name for both Ad and URL reports, but I never changed the variable name in the URL report (see models/ad_reporting__url_report.sql):
I would expect, when using the ad_reporting__ad_passthrough_metrics variable, for the model ad_reporting__url_report to include any metric specified in that variable when compiled.
This has since been resolved within the latest v.1.5.0 release of the package. As such, I will close this ticket out. Thanks @aleix-cd for catching this and opening your PR to address the issue!
Is there an existing issue for this?
Describe the issue
When developing https://github.com/fivetran/dbt_ad_reporting/pull/84, I forgot to change the variable name in
ad_reporting__url_report
.We decided, together with Joe, that we would keep the same variable name for both Ad and URL reports, but I never changed the variable name in the URL report (see
models/ad_reporting__url_report.sql
):Instead, it should be:
Relevant error log or model output
No response
Expected behavior
I would expect, when using the
ad_reporting__ad_passthrough_metrics
variable, for the modelad_reporting__url_report
to include any metric specified in that variable when compiled.dbt Project configurations
Package versions
What database are you using dbt with?
snowflake
dbt Version
v1.5.2
Additional Context
No response
Are you willing to open a PR to help address this issue?