Closed fivetran-catfritz closed 1 year ago
What are your thoughts on manually adding the package models we are updating, but then removing a packages models that are not being updated for Ad Reporting? My only concern is that I wouldn't want to remove a package like Google Ads or Facebook Ads as they are most popular and should always be tested.
@fivetran-joemarkiewicz I think that would make sense and be doable. Maybe this can be something we update the PR checklist specifically for ad_reporting? Something like:
What are your thoughts on manually adding the package models we are updating, but then removing a packages models that are not being updated for Ad Reporting? My only concern is that I wouldn't want to remove a package like Google Ads or Facebook Ads as they are most popular and should always be tested.
@fivetran-joemarkiewicz I think that would make sense and be doable. Maybe this can be something we update the PR checklist specifically for ad_reporting? Something like:
Adjust run_models dbt run and dbt test variables to include:
- This package = true
- Google Ads and Facebook Ads = true
- All other packages = false ?
I actually really like this idea! Would you be interested in incorporating a new entry like this into the maintainer PR template within this PR to be incorporated in the future?
@fivetran-catfritz FYI buildkite is now failing due to Pinterest Ads version dep out of range. This will be resolved once the Pinterest changes are live. Please feel comfortable merging to the release branch with the failed buildkite job. We will confirm all tests pass once all upstream package updates are live on the dbt hub and before merging the release branch to main
.
PR Overview
This PR will address the following Issue/Feature: Update amazon ads package dependency version
This PR will result in the following new package version:
v1.5.0
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR: Update amazon ads version in the packages.yml and documentation
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
none required
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🚚