This PR will address the following Issue/Feature: #13
This PR will result in the following new package version:v0.4.0
The removal of the metrics configs may be breaking for users leveraging the metrics on an older version of dbt-core. Therefore, we will want to make this change breaking.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR simply removes the metrics.yml file and the references to the metrics that users were previously able to take advantage of. These need to be removed as dbt-core >=1.6.0 results in a configs error due to the new metrics flow config which has replaced the previous version we had within this package.
I am open to updating the metrics in this package to be compatible with Metric flow. However, as this is currently stopping users from leveraging the package, I would prefer we remove the old config ASAP before exploring the update to metric flow configs.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[X] dbt compile
[X] dbt run –full-refresh
[X] dbt run
[X] dbt test
[n/a] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[X] The appropriate issue has been linked and tagged
[X] You are assigned to the corresponding issue and this PR
[X] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[X] You have validated these changes and assure this PR will address the respective Issue/Feature.
[X] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[X] You have provided details below around the validation steps performed to gain confidence in these changes.
For validation steps I performed the following:
Confirmed there was an error when doing a normal run with a dbt-core version of 1.6.0 or greater
After seeing the failure I then removed the metrics configs and was able to see the models run successfully
I don't feel too much additional validation is needed as we are simply removing a config that was only used "outside" of the package. Therefore, I am comfortable with the steps taking to validate these changes on my end.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[X] indexed within dbt_project.yml
[X] indexed within integration_tests/dbt_project.yml
[X] CHANGELOG has individual entries for each respective change in this PR
[X] README updates have been applied (if applicable)
[n/a] DECISIONLOG updates have been updated (if applicable)
[X] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[X] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: #13
This PR will result in the following new package version:
v0.4.0The removal of the metrics configs may be breaking for users leveraging the metrics on an older version of dbt-core. Therefore, we will want to make this change breaking.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR simply removes the metrics.yml file and the references to the metrics that users were previously able to take advantage of. These need to be removed as dbt-core >=1.6.0 results in a configs error due to the new metrics flow config which has replaced the previous version we had within this package.
I am open to updating the metrics in this package to be compatible with Metric flow. However, as this is currently stopping users from leveraging the package, I would prefer we remove the old config ASAP before exploring the update to metric flow configs.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
For validation steps I performed the following:
Confirmed there was an error when doing a normal run with a dbt-core version of 1.6.0 or greater
After seeing the failure I then removed the metrics configs and was able to see the models run successfully
I don't feel too much additional validation is needed as we are simply removing a config that was only used "outside" of the package. Therefore, I am comfortable with the steps taking to validate these changes on my end.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🗄️