fivetran / dbt_apple_search_ads

Fivetran's Apple Search Ads dbt package
https://fivetran.github.io/dbt_apple_search_ads/#!/overview
Apache License 2.0
0 stars 2 forks source link

Bugfix/unique test search term report #18

Closed fivetran-reneeli closed 1 year ago

fivetran-reneeli commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_apple_search_ads/issues/16

This PR will result in the following new package version:

v0.2.2

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR: Adds new fields to the unique test for the apple_search_ads__search_term_report model:

        - keyword_id
        - ad_group_id
        - campaign_id
        - organization_id
        - match_type

In addition to the existing search_term_text and date_day

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

dbt test passes. Again our internal data used for development is light and therefore didn't catch this issue before, but the customer who contributed this PR has confirmed that the fields they added now allows the unique test to pass.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

:dancer:
fivetran-reneeli commented 1 year ago

Thank you @yuna-tang for contributing this PR! We will be reviewing this and including this update to the package.

Additional changes:

fivetran-reneeli commented 1 year ago

Updated PR and will wait to regen docs when everything is finalized.

@fivetran-joemarkiewicz ready for re-review

yuna-tang commented 1 year ago

@fivetran-reneeli , I noticed the release version for dbt_apple_search_ads will be v0.2.1. Do you know which version of fivetran/ad_reporting will include this change?

fivetran-reneeli commented 1 year ago

Hi @yuna-tang , it should automatically pull this latest version given the ad reporting parameters currently are [">=0.2.0", "<0.3.0"]!

Note that we moved this to v0.2.2 because I made an accidental release on v0.2.1, but same effect should apply! This has been merged to main so will be closing this out

yuna-tang commented 1 year ago

@fivetran-reneeli Thank you for the confirmation, we are currently using the below ad_reporting package.

When I look into the package.yml, it also has the same range. I assume 1.3.0 ad_reporting will also reflect the latest change.