This PR will result in the following new package version:
v0.3.0 because the source package has a breaking change (and users of the transform package will also need to re seed the country code data)
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
most of the changes happened in the source PR, but here:
i also added a Step in the readme about seeding the country code file, since we don't really document as a necessary step anywhere
we added newly added countries to the one of the seed files so that we can test this out appropriately (ie those countries join properly in the territory report and have non-null data).
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[ ] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[ ] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
validation for this is largely here in the transform package, where i
pointed to the working branch of the source package
added a couple of new countries to one of the territory seed files (specifically Kosovo and two different versions of spelling for the Ivory Coast)
reseeded and reran everything upstream of the territory report
confirmed that the new countries had non-null data from the country code file (so the joins worked)
confirmed that different spellings of a country will indeed split out into distinct rows (but can be aggregated by their identical country codes)
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[ ] DECISIONLOG updates have been updated (if applicable)
[x] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_apple_store_source/issues/8
This PR will result in the following new package version:
v0.3.0 because the source package has a breaking change (and users of the transform package will also need to re seed the country code data)
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR: most of the changes happened in the source PR, but here:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
validation for this is largely here in the transform package, where i
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
☔