New feature: Unioning source data - Githubissues

fivetran / dbt_facebook_ads_source

Fivetran data models for Facebook Ads built using dbt.

https://fivetran.github.io/dbt_facebook_ads_source/

Apache License 2.0

14 stars 16 forks source link

New feature: Unioning source data #18

Closed pawelngei closed 2 years ago

pawelngei commented 2 years ago

Are you a current Fivetran customer? Yes, Pawel Ngei, Pattern Brands

What change(s) does this PR introduce?

Introduce the ability to union data from multiple schemas databases, as per https://github.com/fivetran/dbt_klaviyo_source/pull/9 (for Klaviyo)

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[x] No (please provide explanation how the change is non breaking below.)

Is this PR in response to a previously created Issue

[ ] Yes, Issue [link issue number here]
[x] No

How did you test the PR changes?

[ ] CircleCi
[x] Other (please provide additional testing details below)

Pattern Brands data, two datasets from Facebook Ads connector

Select which warehouse(s) were used to test the PR

[ ] BigQuery
[ ] Redshift
[x] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

:building_construction:

Feedback

Will need to remember to add a Readme note about the basic_ad table to the other two plugins, it's not advertised enough

fivetran-joemarkiewicz commented 2 years ago

Thanks again so much for putting the effort into this PR @pawelngei! There are a few minor changes (tests and formatting updates) that I am going to apply before we include this in a live version of the package. Therefore I am changing the base branch to be a working branch that I will apply these updates to.

Thanks so much!