fivetran / dbt_facebook_ads_source

Fivetran data models for Facebook Ads built using dbt.
https://fivetran.github.io/dbt_facebook_ads_source/
Apache License 2.0
14 stars 16 forks source link

documentation/basic-ad-update #31

Closed fivetran-joemarkiewicz closed 10 months ago

fivetran-joemarkiewicz commented 10 months ago

PR Overview

This PR will address the following Issue/Feature: #26 and #35

This PR will result in the following new package version: v0.7.1

This will not be a breaking change as this only updates documentation.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Documentation Updates

Additional updates

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

In order to validate these steps I went through the creation of a new Facebook Ads connector facebook_ads_basic_ad_test and confirmed the basic_ad pre-built report is now synced by default and if you wish to enable/disable the table you will do so via the schema tab.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

🏗️
fivetran-catfritz commented 10 months ago

@fivetran-joemarkiewicz Hey really really really sorry I accidentally committed to your branch... I undid it though so you can ignore.