This PR will address the following Issue/Feature: #26 and #35
This PR will result in the following new package version:v0.7.1
This will not be a breaking change as this only updates documentation.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Documentation Updates
The prerequisite steps for generating the basic_ad pre-built report have been modified to reflect the current state of the Facebook Ads connector.
Adds the DECISIONLOG to clarify why there exist differences among aggregations across different grains.
Additional updates
This PR includes the addition of the auto releaser and 2nd reviewer github actions to be leveraged following merge to main.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[n/a] dbt compile
[n/a] dbt run –full-refresh
[n/a] dbt run
[n/a] dbt test
[n/a] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[X] The appropriate issue has been linked and tagged
[X] You are assigned to the corresponding issue and this PR
[X] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[X] You have validated these changes and assure this PR will address the respective Issue/Feature.
[X] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[X] You have provided details below around the validation steps performed to gain confidence in these changes.
In order to validate these steps I went through the creation of a new Facebook Ads connector facebook_ads_basic_ad_test and confirmed the basic_ad pre-built report is now synced by default and if you wish to enable/disable the table you will do so via the schema tab.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[X] indexed within dbt_project.yml
[X] indexed within integration_tests/dbt_project.yml
[X] CHANGELOG has individual entries for each respective change in this PR
[X] README updates have been applied (if applicable)
[X] DECISIONLOG updates have been updated (if applicable)
[n/a] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[n/a as no code or yml changes were applied] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: #26 and #35
This PR will result in the following new package version:
v0.7.1
This will not be a breaking change as this only updates documentation.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Documentation Updates
basic_ad
pre-built report have been modified to reflect the current state of the Facebook Ads connector.Additional updates
main
.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
In order to validate these steps I went through the creation of a new Facebook Ads connector
facebook_ads_basic_ad_test
and confirmed thebasic_ad
pre-built report is now synced by default and if you wish to enable/disable the table you will do so via the schema tab.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🏗️