fivetran / dbt_facebook_ads_source

Fivetran data models for Facebook Ads built using dbt.
https://fivetran.github.io/dbt_facebook_ads_source/
Apache License 2.0
14 stars 16 forks source link

[Bug] Update Creative History Unique test #33

Closed fivetran-avinash closed 7 months ago

fivetran-avinash commented 7 months ago

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

🧪
fivetran-avinash commented 7 months ago

@fivetran-joemarkiewicz Interesting, I was able to merge without the second reviewer approving, does something need to be modified in the settings?

fivetran-joemarkiewicz commented 7 months ago

@fivetran-avinash the second reviewer is not required before merge. We should probably update that, but we need to fix the whole second approver process as well. Thanks for raising!