Closed fivetran-avinash closed 7 months ago
@fivetran-joemarkiewicz Interesting, I was able to merge without the second reviewer approving, does something need to be modified in the settings?
@fivetran-avinash the second reviewer is not required before merge. We should probably update that, but we need to fix the whole second approver process as well. Thanks for raising!
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
New test does not fail on
stg_facebook_ads__creative_history
.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🧪