This PR will result in the following new package version:
v0.7.3
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
Resolved the "duplicate column" error that would arise when the facebook_ads__basic_ad_passthrough_metrics variable included reach or frequency. Reach and frequency are included by default in the stg_facebook_ads__basic_ad model but will only persist to downstream transform models if specified in the facebook_ads__basic_ad_passthrough_metrics variable.
Under the Hood
Updated the maintainer PR template to our most up-to-date standards.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt run –full-refresh && dbt test
[ ] dbt run (if incremental models are present)
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[x] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[x] Detailed validation steps have been provided below
Detailed Validation
Please share any and all of your validation steps:
So in my dev dbt_project.yml, I added the following config:
PR Overview
This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_facebook_ads_source/issues/34
This PR will result in the following new package version:
v0.7.3
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
facebook_ads__basic_ad_passthrough_metrics
variable includedreach
orfrequency
.Reach
andfrequency
are included by default in thestg_facebook_ads__basic_ad
model but will only persist to downstream transform models if specified in thefacebook_ads__basic_ad_passthrough_metrics
variable.Under the Hood
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
So in my dev
dbt_project.yml
, I added the following config:I expected the above inclusion of
reach
(but notfrequency
actually due to the alias) to cause a failure, which it did instg_facebook_ads__basic_ad
With this branch, running
dbt run +ad_reporting
completed successfullyAnd I see
reach
andfake_freq_name
in my facebook ads models (and with non-zero/null values)If you had to summarize this PR in an emoji, which would it be?
📊