fivetran / dbt_facebook_ads_source

Fivetran data models for Facebook Ads built using dbt.
https://fivetran.github.io/dbt_facebook_ads_source/
Apache License 2.0
14 stars 16 forks source link

reach + frequency metrics #35

Closed fivetran-jamie closed 4 months ago

fivetran-jamie commented 4 months ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_facebook_ads_source/issues/34

This PR will result in the following new package version:

v0.7.3

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

Under the Hood

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please share any and all of your validation steps:

So in my dev dbt_project.yml, I added the following config:

vars:
  facebook_ads__basic_ad_passthrough_metrics: 
    - name: 'reach'
    - name: 'frequency'
      alias: 'fake_freq_name'

I expected the above inclusion of reach (but not frequency actually due to the alias) to cause a failure, which it did in stg_facebook_ads__basic_ad

image

With this branch, running dbt run +ad_reporting completed successfully

image

And I see reach and fake_freq_name in my facebook ads models (and with non-zero/null values)

image image

If you had to summarize this PR in an emoji, which would it be?

📊