fivetran / dbt_facebook_ads_source

Fivetran data models for Facebook Ads built using dbt.
https://fivetran.github.io/dbt_facebook_ads_source/
Apache License 2.0
14 stars 16 forks source link

Bugfix/qdm #37

Closed fivetran-jamie closed 5 months ago

fivetran-jamie commented 5 months ago

PR Overview

This PR will address the following Issue/Feature: From our QDM Error analysis: solution_caused_error: constant expressions are not supported in partition by clauses

This PR will result in the following new package version:

v0.7.4

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please share any and all of your validation steps:

Actually addresses issue I recreated the issue in Buildkite by adjusting the names of few history tables' identifier variables to point to non-existent tables (which union_data will create null versions of)

  facebook_ads_source:
    facebook_ads_account_history_identifier: "facebook_ads_account_history_data_WRONG_FOR_TESTING"
    facebook_ads_ad_history_identifier: "facebook_ads_ad_history_data"
    facebook_ads_ad_set_history_identifier: "facebook_ads_ad_set_history_data_WRONG_FOR_TESTING"
    facebook_ads_basic_ad_identifier: "facebook_ads_basic_ad_data"
    facebook_ads_campaign_history_identifier: "facebook_ads_campaign_history_data_WRONG_FOR_TESTING"
    facebook_ads_creative_history_identifier: "facebook_ads_creative_history_data"

Using my branch, Redshift now passes on Buildkite with this setup

Validate updates consistency tests added and passing

image