This PR will result in the following new package version:
1.3.1
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
To ensure SQL server compatibility, I made the following changes:
SQL changes
updated any references to booleans to use the dbt.type_boolean() macro (and read booleans differently)
convert any conversions that are date(field) to cast(field as date)
remove any group by that uses digits (need to explicitly reference the columns)
use sql-server specific date functions, as the dbt_date package does not support sql-server
lots of date casting
use dbt.current_timestamp() instead of the backcompat version for sql server
remove distinct from string_agg calls <-- this change currently will affect everyone. should i make it sql-server specific, or is that overkill?
remove order by of CTEs (for sql server only)
Buildkite changes
Added SQL server creds to the pre-command file
Added step to pipeline.yml
Added profile to sample.profiles.yml
Added SQL-server-specific requirements.txt file
Added SQL-server specific logic to run_models.sh in order to properly set up the right environment in BK's docker container for sql server
Docs
Updated README to include sql server compatibility
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[x] dbt run –vars (if applicable)
Will provide Hex sheet for validation that non-SQL Server targets have not been affected.
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[ ] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
See Hex linked in Height! Basically just confirmed that the row counts did not change for any models when running on our BigQuery fivetran_log connector data
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[ ] DECISIONLOG updates have been updated (if applicable)
[ ] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_fivetran_log/issues/94
also includes merged code from https://github.com/fivetran/dbt_fivetran_log/pull/102 (i merged 1.3.latest into my sql-server branch locally)
This PR will result in the following new package version:
1.3.1
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
To ensure SQL server compatibility, I made the following changes:
booleans
to use thedbt.type_boolean()
macro (and read booleans differently)date(field)
tocast(field as date)
group by
that uses digits (need to explicitly reference the columns)dbt.current_timestamp()
instead of the backcompat version for sql serverdistinct
from string_agg calls <-- this change currently will affect everyone. should i make it sql-server specific, or is that overkill?order by
of CTEs (for sql server only)pre-command
filepipeline.yml
sample.profiles.yml
run_models.sh
in order to properly set up the right environment in BK's docker container for sql serverPR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Will provide Hex sheet for validation that non-SQL Server targets have not been affected.
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
See Hex linked in Height! Basically just confirmed that the row counts did not change for any models when running on our BigQuery fivetran_log connector data
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🪁