fivetran / dbt_fivetran_log

Data models for Fivetran's internal log connector built using dbt.
https://fivetran.github.io/dbt_fivetran_log/
Apache License 2.0
30 stars 24 forks source link

dbt-sqlserver compatibility 📯 #101

Closed fivetran-jamie closed 8 months ago

fivetran-jamie commented 9 months ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_fivetran_log/issues/94

also includes merged code from https://github.com/fivetran/dbt_fivetran_log/pull/102 (i merged 1.3.latest into my sql-server branch locally)

This PR will result in the following new package version:

1.3.1

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

To ensure SQL server compatibility, I made the following changes:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Will provide Hex sheet for validation that non-SQL Server targets have not been affected.

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

See Hex linked in Height! Basically just confirmed that the row counts did not change for any models when running on our BigQuery fivetran_log connector data

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

🪁