fivetran / dbt_fivetran_log

Data models for Fivetran's internal log connector built using dbt.
https://fivetran.github.io/dbt_fivetran_log/
Apache License 2.0
30 stars 24 forks source link

[Feature] Provide deleted status for deleted connectors within connector_status model #108

Closed fivetran-joemarkiewicz closed 2 months ago

fivetran-joemarkiewicz commented 8 months ago

Is there an existing feature request for this?

Describe the Feature

Currently the Fivetran Log raw data does not provide a deleted status for connectors when they are removed. Therefore, if a connector is deleted it will report as the last known status before it was deleted (ie. paused, broken, etc.). This can lead to confusing results where a connector will be reported as one status, but it will actually be deleted and should be recognized as such.

This Feature Request is to ensure the deleted status may be displayed properly within the fivetran_platform__connector_status end model.

Describe alternatives you've considered

As of know the only alternative is to filter our deleted connectors. I don't feel this is the best option and we should instead still report on these connectors, but mark them accordingly as deleted.

Are you interested in contributing this feature?

Anything else?

No response

fivetran-jamie commented 8 months ago

i imagine the code change in the connector_status model would look just like our paused-logic

but first we'll need to add _fivetran_deleted to the staging connector model (it's in the columns macro but not the model itself)

fivetran-joemarkiewicz commented 2 months ago

This has been addressed in the latest release of the Fivetran Log package. Closing out this issue.