Closed fivetran-jamie closed 1 year ago
@fivetran-joemarkiewicz added your changes! also for validation, i added some extra lines to the seed file
So, running before adding new dates:
I then add these new rows to the log
seed file to simulate a sync of the media_insights
table the next day (2021-12-10)
i dbt seed --full-refresh
i perform an incremental run, resulting in the following expected output (a new record for media_insights
)
PR Overview
This PR will address the following Issue/Feature:
height task T-390568 https://github.com/fivetran/dbt_fivetran_log/issues/83
This PR will result in the following new package version:
considering we are renaming the package, v1.0.0?
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
fivetran_log
prefix on all variables and models tofivetran_platform
_stg_fivetran_platform
and_fivetran_platform
fivetran_platform
_fivetran_synced
in some sourcesaccount_membership
table which was deprecated - https://github.com/fivetran/dbt_fivetran_log/issues/83what this does NOT do:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
ran the two versions of the package simultaneously (since they have different project + model names). I looked at various models, but here I will focus on the audit table model, since i updated the the Bigquery + Spark incremental strategy for that model
ran a full refresh and spot checked different tables + connectors, but here are the total aggregates compared
ran an incremental run
everything checks out there -- should i validate any other way.. ?
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📛