This PR will address the following Issue/Feature: No linked issue in GitHub. This relates to the Height ticket T-521886
This PR will result in the following new package version:v1.1.0
Since this is adding a new field schema_name to the fivetran_platform__audit_table model which is an incremental one, this will result in a breaking change and require users to run a --full-refresh when upgrading.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🚨 Feature Updates (Breaking Change) 🚨
The below change was made to an incremental model. As such, a dbt run --full-refresh will be required following an upgrade to capture the new column.
Added schema_name to the fivetran_platform__audit_table end model. This schema name field is captured from the message_data JSON within the log source table. In cases where the schema_name is not provided a coalesce was added to replicate the connector_name as the `schema_name.
Documentation Updates
Fixed links in the README models section to properly redirect to the dbt hosted docs for the relevant models.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[X] dbt compile
[X] dbt run –full-refresh
[X] dbt run
[X] dbt test
[n/a] dbt run –vars (if applicable) no vars were tested in the development of this update
Before marking this PR as "ready for review" the following have been applied:
[X] The appropriate issue has been linked and tagged
[X] You are assigned to the corresponding issue and this PR
[X] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[X] You have validated these changes and assure this PR will address the respective Issue/Feature.
[X] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[X] You have provided details below around the validation steps performed to gain confidence in these changes.
In order to validate these changes I wanted to make sure there were no changes to the row count which would validate that the addition of the new schema made no changes to the underlying source. However, when validating this I actually noticed that the changes I had made in my branch was larger than the current live version of the platform package 🤔
When investigating this further I found there were only a few occurrences where additional records occurred. I was able to isolate the differences to three table_name records: fivetran_audit, user, ticket.
When taking a deeper look I was able to see that these three tables actually existed in multiple schemas. For example, the user table exists in both the snowflake_stage_jira and the snowflake_stage_zendesk schemas. The same goes for the ticket table with Zendesk and HubSpot schemas.
When looking at the current version I was able to see that it looks like this difference is not fully captured and the row insert or replace sums are being incorrectly aggregated all together.
To further validate, I was able to prove that the Fivetran UI for these tables in fact matches what we see in the updates within this branch. For proof of this validation, please investigate the Usage tab for the snowflake_stage connector and see for these specific tables the totals in the audit_table match what we see in the UI.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[X] indexed within dbt_project.yml
[X] indexed within integration_tests/dbt_project.yml
[X] CHANGELOG has individual entries for each respective change in this PR
[X] README updates have been applied (if applicable)
[n/a] DECISIONLOG updates have been updated (if applicable)
[X] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[X] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: No linked issue in GitHub. This relates to the Height ticket T-521886
This PR will result in the following new package version:
v1.1.0Since this is adding a new field
schema_nameto thefivetran_platform__audit_tablemodel which is an incremental one, this will result in a breaking change and require users to run a--full-refreshwhen upgrading.Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🚨 Feature Updates (Breaking Change) 🚨 The below change was made to an incremental model. As such, a
dbt run --full-refreshwill be required following an upgrade to capture the new column.schema_nameto thefivetran_platform__audit_tableend model. This schema name field is captured from themessage_dataJSON within thelogsource table. In cases where the schema_name is not provided a coalesce was added to replicate theconnector_nameas the `schema_name.Documentation Updates
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
In order to validate these changes I wanted to make sure there were no changes to the row count which would validate that the addition of the new schema made no changes to the underlying source. However, when validating this I actually noticed that the changes I had made in my branch was larger than the current live version of the platform package 🤔
When investigating this further I found there were only a few occurrences where additional records occurred. I was able to isolate the differences to three table_name records:
fivetran_audit,user,ticket.When taking a deeper look I was able to see that these three tables actually existed in multiple schemas. For example, the
usertable exists in both thesnowflake_stage_jiraand thesnowflake_stage_zendeskschemas. The same goes for thetickettable with Zendesk and HubSpot schemas.When looking at the current version I was able to see that it looks like this difference is not fully captured and the row insert or replace sums are being incorrectly aggregated all together.
To further validate, I was able to prove that the Fivetran UI for these tables in fact matches what we see in the updates within this branch. For proof of this validation, please investigate the Usage tab for the snowflake_stage connector and see for these specific tables the totals in the audit_table match what we see in the UI.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🌴