No issue made, I uncovered this when validating a separate issue's PR.
dbt test fails on incremental runs only. Passes on full refreshes
This PR will result in the following new package version:
1.3.0 -- folks should run a full refresh in case they have duplicates currently, also this will be batched with breaking changes
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
I was able to resolve the test failures by adjusting this line to use a > instead of >=
Bug Fixes
Tightened incremental logic in fivetran_platform__audit_table, which was seeing duplicates on incremental runs (PR #97).
If you are seeing uniqueness test failures on the unique_table_sync_key field, please run a full refresh before upgrading to this version of the package.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[ ] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[ ] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
See Hex notebook in Height (this issue doesn't have a specific height task but it's linked in all the other fivetran platform tickets i'm working on this sprint)
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[ ] DECISIONLOG updates have been updated (if applicable)
[ ] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[ ] docs were regenerated (unless this PR does not include any code or yml updates) -- waiting to do so on release branch
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature:
No issue made, I uncovered this when validating a separate issue's PR.
dbt testfails on incremental runs only. Passes on full refreshesThis PR will result in the following new package version:
1.3.0 -- folks should run a full refresh in case they have duplicates currently, also this will be batched with breaking changes
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
I was able to resolve the test failures by adjusting this line to use a
>instead of>=Bug Fixes
fivetran_platform__audit_table, which was seeing duplicates on incremental runs (PR #97).unique_table_sync_keyfield, please run a full refresh before upgrading to this version of the package.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
See Hex notebook in Height (this issue doesn't have a specific height task but it's linked in all the other fivetran platform tickets i'm working on this sprint)
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🪠