fivetran / dbt_fivetran_utils

Helper utils for our packages
29 stars 19 forks source link

add sql server quote-wrapping #138

Open fivetran-jamie opened 9 months ago

fivetran-jamie commented 9 months ago

What change does this PR introduce?

Adds SQLserver logic to the `wrap_in_quotes()` macro. this was necessary as the default logic (using backticks instead of double quotes) did not work with sql server in the Fivetran Platform package for the time being, i have [excluded](https://github.com/fivetran/dbt_fivetran_log/blob/main/.buildkite/scripts/run_models.sh#L70-L72) the `drop_schemas_automation` run for sqlserver to get around the error. **If this PR introduces a new macro, how did you test the new macro?**

In Buildkite, where it is called in the drop_schemas_automation macro

If this PR introduces a modification to an existing macro, which packages is the macro currently present in and what steps were taken to test compatibility across packages?

added sqlserver adapter version of the macro only, and it does not reference any other macros.

Did you update the README to reflect the macro addition/modifications?