fivetran / dbt_fivetran_utils

Helper utils for our packages
29 stars 19 forks source link

bugfix/union-data #82

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

What change does this PR introduce?

## Bug Fixes - The `union_data` macro has been adjusted to establish a source relation instead of a floating relation. - To leverage this macro in an environment where `dbt_fivetran_utils` is already installed, you can add the following to your `packages.yml` to install this version of the package: ```yml - git: https://github.com/fivetran/dbt_fivetran_utils.git revision: bugfix/union-data warn-unpinned: false ``` - You can then add the following to your `dbt_project.yml` to dispatch this package version (`fivetran_utils_union`) in place of the original package (`dbt_fivetran_utils`). ```yml dispatch: - macro_namespace: fivetran_utils search_order: ['fivetran_utils_union','fivetran_utils'] ``` **If this PR introduces a new macro, how did you test the new macro?**

This is not a new macro, instead it is changes to the existing union_data macro.

If this PR introduces a modification to an existing macro, which packages is the macro currently present in and what steps were taken to test compatibility across packages?

This was tested on the Xero dataset and success was found! The key update needed here however is a source.yml for each source must be created. See below for the two source.yml I created in my development project (notice the only changes are the source name and schema name): image

In the end you can see the union working as intended! image

Did you update the README to reflect the macro addition/modifications?

No README changes required.

fivetran-joemarkiewicz commented 2 years ago

I have a strong feeling this PR would also address Issue #52