Closed pawelngei closed 2 years ago
Thanks again so much for putting the effort into this PR @pawelngei! There are a few minor changes (tests and formatting updates) that I am going to apply before we include this in a live version of the package. Therefore I am changing the base branch to be a working branch that I will apply these updates to.
Thanks so much!
Are you a current Fivetran customer? Yes, Pawel Ngei, Pattern Brands
What change(s) does this PR introduce?
Does this PR introduce a breaking change?
Is this PR in response to a previously created Issue
How did you test the PR changes?
Local Pattern Brands data
Select which warehouse(s) were used to test the PR
:musical_keyboard:
Notes
Needs a change in
package.yml
oncegoogle_ads_source
is published.I wasn't able to generate docs not knowing what profile I should use. Maybe you could add it to the readme?
I'll add the links to the changelog shortly.