fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

Bugfix/new google ads #24

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This change captures updates to the Google Ads API version of the dbt package. The Google Ads API version of the package changed since the last update. The main highlights include:

Does this PR introduce a breaking change?

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [X] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [X] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 🩹 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-sheringuyen commented 2 years ago

Everything looks good to me! Curious, was there supposed to be a message attached to this like we discussed in standup?

Just confirming this is the correct error message like I received in the source package: 00:07:04 Warning in test dbt_expectations_expect_column_values_to_not_match_regex_list_stg_google_ads__ad_history_source_final_urls__any___ (models/google_ads_connector/stg_google_ads.yml) 00:07:04 Got 1 result, configured to warn if != 0 00:07:04 00:07:04 compiled SQL at target/compiled/google_ads_source/models/google_ads_connector/stg_google_ads.yml/dbt_expectations_expect_column_f02cb56d69a9df1e600b3958899ceaa5.sql 00:07:04 00:07:04 Done. PASS=0 WARN=1 ERROR=0 SKIP=0 TOTAL=1