fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

[Bug] Google AdWords Configuration instructions requires reports not (or no longer) available in Fivetran #30

Closed baer closed 2 years ago

baer commented 2 years ago

Is there an existing issue for this?

Describe the issue

The configuration for the Google AdWords connector in the README requires three custom report types: FINAL_URL_REPORT, CRITERIA_PERFORMANCE_REPORT, CLICK_PERFORMANCE_REPORT. There appear to be two issues:

  1. The Fivetran connector only has a field for "Report Name," but not "Report Type." These may be interchangeable but, it was the first thing I noticed.
  2. Assuming that "Report Name" and "Report Type" are synonymous, there are no reports that correspond to the three that are required.
Screen Shot 2022-05-12 at 12 32 01 PM

Potentially related, Fivetran recently deprecated the Google Ads API and converted all existing connectors to Google Adwords. Our account had a Google Ads connector that was converted that had a click_performance report. It looks like Fivetran automatically changed that report to click_view and renamed many of the attributes. This makes me think that the README may have outdated report and field names.

Screen Shot 2022-05-12 at 12 34 00 PM

Thank you for your support!

Relevant error log or model output

No response

Expected behavior

The configuration in the README should apply to the Fivetran connector.

dbt Project configurations

NA

Package versions

  - package: fivetran/ad_reporting
    version: [">=0.6.0", "<0.7.0"]

What database are you using dbt with?

snowflake

dbt Version

1.1

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-joemarkiewicz commented 2 years ago

Hi @baer thanks for opening this issue.

From the looks of your issue it seems you may actually be using the Google Ads API and therefore do not need to create the custom reports. Would you be able to check your Connector connection details and let me know what API type your connector is using? If it says Google Ads, then you will just need to update the API configuration of the package by setting the api_source variable to be google_ads. image

baer commented 2 years ago

Thank you for the quick response! Fivetran now only offers a single Google Ads connector type called "Google Ads (Adwords)." See Below. I assumed that, being called "Google Ads (Adwords)" this corresponds to the Adwords API Configuration documentation.

If I'm understanding correctly, my connector does not require any additional reports to work with this package. Even though the name of the connector includes the word "Adwords," it corresponds with the Google Ads API Configuration

Sounds like this if just a README clarity issue after a Fivetran rename :). Easy fix. Thanks again!

Screen Shot 2022-05-13 at 6 32 43 AM
fivetran-joemarkiewicz commented 2 years ago

@baer Correct!

Were you able to specify the google_ads_api variable and see the package succeed? I also agree that the naming of the connector is a bit confusing. Especially since the product by Google is still called Adwords, but the API is now Google Ads 😕 .

I will check with our product team for naming consistency, but let me know if the changes help your package succeed on your end!

fivetran-joemarkiewicz commented 2 years ago

HI @baer I believe the above will have solved the issue you were experiencing. I will close this ticket, but please feel free to open a new one if you are still experiencing issues.