Closed fivetran-joemarkiewicz closed 2 years ago
Thanks for the review @fivetran-sheringuyen! I addressed your inline comments in the latest commit. Also, to answer your additional questions:
I am also getting the same error I got running dbt test in the source package -- is it expected?
final_urls
field possibly containing multiple urls. In a similar fashion where we select the latest historical record for some history models, in this case we select only one url to include in the final model. This warning is by design to raise awareness to users that a url is being intentionally cut off. See here for the specific test that is providing the warning.Additionally, I want to confirm that only adwords has the *_click_performance model.
click_performance
. This is not supported or needed with the data we leverage from the google_ads
version of the api.
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
The
api_source
variable is now defaulted togoogle_ads
as opposed toadwords
. The Adwords API has since been depricated by Google and is now no longer the standard API for the Google Ads connector. Please ensure you are using a Google Ads API version of the Fivetran connector before upgrading this package.adwords
version of this package will be fully removed from the package in August of 2022 (when the V2 updates roll out).Did you update the CHANGELOG?
Does this PR introduce a breaking change?
The default nature of the
api_source
has changed. As such, we should treat this as a breaking change.Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🍎 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.