fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

Feature/v2 updates #34

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR includes the following updates:

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🤌 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 2 years ago

FYI the base branch is feature/google-ads-api-default as that branch will be merged prior to this one and I want to make sure I am not duplicating reviews from the changes made in PR #32

fivetran-joemarkiewicz commented 2 years ago

Thanks so much for this review @fivetran-sheringuyen!

I was able to address all your inline comments with the exception of the questions around the url vs utm debate. I think we should chat more about this live. Once we settle a firm approach on this I will regenerate the docs.

fivetran-joemarkiewicz commented 2 years ago

Things to update before merging: